Allow llvm-coverage to write file on webdriver exit#41141
Merged
jschwe merged 3 commits intoservo:mainfrom Feb 4, 2026
Merged
Conversation
Narfinger
force-pushed
the
coverage-test
branch
from
08fddf4 to
8e9bfc5
Compare
jschwe
reviewed
Dec 9, 2025
Narfinger
force-pushed
the
coverage-test
branch
from
8b64a21 to
91d41f8
Compare
Signed-off-by: Narfinger <[email protected]>
Narfinger
force-pushed
the
coverage-test
branch
from
91d41f8 to
78b4437
Compare
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Narfinger <[email protected]>
Contributor
Author
|
@jschwe Should be ready now. |
Signed-off-by: Narfinger <[email protected]>
jschwe
approved these changes
Feb 4, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
cfgto servo that uses the llvm profile-runtime function for writing the coverage file to disk.When the webdriver shuts down we should make sure to write the llvm_coverage file. This is only required on platforms like android or ohos, where there is no real exiting of the process, so we need to manually dump the profile to disk.
See also https://clang.llvm.org/docs/SourceBasedCodeCoverage.html
Testing: Tested '/mach build -r --coverage && ./mach test-wpt -r --coverage' and there do not seem any parsing errors anymore.
Fixes: #40942