Merged
Conversation
Unify various `encodable` and `encode` methods from actors in an `ActorEncode` trait, making it more consistent. Add an `ActorRegistry::encode` method that finds an actor by name and then returns its serialized version. Add an `ActorMsg` struct to avoid creating repeated structs for simple serializations. There are two exceptions for this, `EncodableConsoleMessage` and `NodeInfo`. These also have an `encode` method, but they are not actors, so including them in this trait doesn't make much sense. Besides, they have special requirements so it is better to keep them separate. Signed-off-by: eri <[email protected]>
servo-highfive
added
the
S-awaiting-review
jdm
approved these changes
Dec 8, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify various
encodableandencodemethods from actors in anActorEncodetrait, making it more consistent.Add an
ActorRegistry::encodemethod that finds an actor by name and then returns its serialized version.Add an
ActorMsgstruct to avoid creating repeated structs for simple serializations.There are two exceptions:
EncodableConsoleMessageandNodeInfo. These also have anencodemethod, but they are not actors, so including them in this trait doesn't make much sense. Besides, they have special requirements so it is better to keep them separate.Testing: Manual testing in
about:debugging.