fonts: Replace deprecated xml-rs with [email protected]#41134
fonts: Replace deprecated xml-rs with [email protected]#41134mrobinson merged 5 commits intoservo:mainfrom
xml-rs with [email protected]#41134Conversation
Signed-off-by: Ajay Singh <[email protected]>
|
cc:- @mrobinson |
|
please read our AI contributions policy before contributing. |
|
Thanks! @delan. I think using AI isn't that bad anyways and for this very minor change it wouldn't have to be a very big issue. I have updated the PR description anyways. |
|
thanks, the new description is much better :) |
it’s not about using AI being bad or not, we have a policy in place and we should respect it! |
|
I'll take care of it.
…On Mon, 8 Dec, 2025, 6:05 pm Taym Haddadi, ***@***.***> wrote:
*Taym95* left a comment (servo/servo#41134)
<#41134 (comment)>
Thanks! @delan <https://github.com/delan>. I think using AI isn't that
bad anyways and for this very minor change it wouldn't have to be a very
big issue. I have updated the PR description anyways.
it’s not about using AI being bad or not, we have a policy in place and we
should respect it!
—
Reply to this email directly, view it on GitHub
<#41134 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7B2GCIBDDYAPFKT4RFPJL4AVV7VAVCNFSM6AAAAACOLUFSHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMRWG4YTENRVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
take care of what? |
This seems to need changes in order to compile against the newer version of |
Signed-off-by: Ajay Singh <[email protected]>
8aa030f to
0c7dc20
Compare
|
@mrobinson Fixed it. |
Signed-off-by: Ajay Singh <[email protected]>
|
🔨 Triggering try run (#20057489980) for Android |
|
✨ Try run (#20057489980) succeeded. |
mrobinson
left a comment
There was a problem hiding this comment.
Looks good, with one small change.
xml-rs with [email protected]
Signed-off-by: Ajay Singh <[email protected]>
|
Done! |
Signed-off-by: Ajay Singh <[email protected]>
Head branch was pushed to by a user without write access
This PR updates
xml-rscrate. On the official crate site it is mentioned to change the name of the crate withxmland update it.It is also explicitly mentioned that their won't be any code changes so I think their isn't any major API changes.Reference:- https://crates.io/crates/xml-rs/0.8.28
Testing: It doesn't require testing because this is just the change in the crate's name