Remove our macOS-only task-info crate#41132
Merged
mrobinson merged 1 commit intoservo:mainfrom Dec 8, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
jschwe
reviewed
Dec 8, 2025
jschwe
approved these changes
Dec 8, 2025
servo-highfive
removed
the
S-awaiting-review
This crate is just using system APIs to get the resident and virtual memory size of the current process. We can do this directly with `mach2`, which also allows more flexibility if we want to fetch other values in the future. This does require duplicating `mach2` as the version used by `gilrs` is older. Presumably, some future release of `gilrs` will upgrade soon. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
remove-rust-task-info
branch
from
5ac3d2d to
b735364
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
mrobinson
added a commit
to servo/book
that referenced
this pull request
Dec 9, 2025
This crate was removed in servo/servo#41132. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue bot
pushed a commit
to servo/book
that referenced
this pull request
Dec 9, 2025
This crate was removed in servo/servo#41132. Signed-off-by: Martin Robinson <[email protected]> Signed-off-by: Martin Robinson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This crate is just using system APIs to get the resident and virtual
memory size of the current process. We can do this directly with
mach2, which also allows more flexibility if we want to fetch othervalues in the future.
This does require duplicating
mach2as the version used bygilrsisolder. Presumably, some future release of
gilrswill upgrade soon.Testing: There aren't really tests for this, but I tested it manually by
running the memory reporter and ensuring that both the old and new values were
the same.