mach: Properly handle empty commit message in the WPT export script#41128
mach: Properly handle empty commit message in the WPT export script#41128mrobinson merged 3 commits intoservo:mainfrom
Conversation
Signed-off-by: chenura999 <[email protected]>
|
@chenura999 Do you have a link to where this produced an error during WPT import? |
|
@mrobinson The failure log showed a I verified this behavior locally with a reproduction script and the fix ensures we default to an empty string in that case. |
|
@chenura999 Can you provide a link to that job? I'm not sure which run it was a part of. |
I tried to access the run again, but the link seems to be expired or invalid now (404). However, I can confirm the error was a TypeError: argument of type 'NoneType' is not iterable in The fix I pushed ensures we default to an empty string so this doesn't happen again. |
|
I think this is the run with that job - https://github.com/servo/servo/actions/runs/20022685522/job/57412925025 |
Thanks for the log! That confirms it was the NoneType error in the WPT export script caused by an empty PR body. I've pushed a fix for that script to this branch as well, so the CI should pass now. |
This looks was written using AI. |
mrobinson
left a comment
There was a problem hiding this comment.
We shouldn't be landing PRs with empty bodies, but this fix seems fine anyhow.
|
I have rewritten the PR description in case it was written via LLM. @chenura999, we really appreciate the contributions, but please avoid using AI tools to generate commits or descriptions. It's nothing personal -- just the policy we currently have in place. If you aren't confident about the PR description your write yourself, feel free to ask a reviewer to look it over and make edits. Thank you! |
Thank you really appreciate it ❤️ |
Properly handle empty commit messages when processing commits during WPT export. We shouldn't be landing commits with empty messages into Servo, but sometimes when a PR is in process, the body is empty. In those cases, this change avoids an error during job execution.