webgl: Unconditionally decrement busy count of WebGL contexts.#41094
Merged
mukilan merged 1 commit intoservo:mainfrom Dec 6, 2025
Merged
webgl: Unconditionally decrement busy count of WebGL contexts.#41094mukilan merged 1 commit intoservo:mainfrom
mukilan merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56545) with upstreamable changes. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56545) title and body. |
jdm
approved these changes
Dec 6, 2025
servo-highfive
removed
the
S-awaiting-review
The current logic returns early without decrementing the busy count if there are the swap chain doesn't have a front surface. This happens if the context was created but never used for rendering, as seen in the linked issue. Since the count is always incremented when locking, this causes the count to never reach zero, causing the cleanup logic in `remove_webgl_context` to skip freeing the context and associated resources. Fixes servo#41082. Signed-off-by: Mukilan Thiyagarajan <[email protected]>
mukilan
force-pushed
the
fix-webgl-crash
branch
from
ce4c360 to
a28d927
Compare
servo-highfive
added
the
S-awaiting-review
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56545). |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic returns early without decrementing the busy count if the swap chain doesn't have a front surface. This happens if the context was created but never used for rendering, as seen in the linked issue. Since the count is always incremented when locking, this causes the count to never reach zero, causing the cleanup logic in
remove_webgl_contextto skip freeing the context and associated resources.Fixes #41082.
Testing: A new crash test is added.