Skip to content

Guard MediaElementAudioSourceNode against closed contexts and add crash test#41092

Merged
jdm merged 2 commits intoservo:mainfrom
Taym95:mediaelement-audio-inert-check
Dec 6, 2025
Merged

Guard MediaElementAudioSourceNode against closed contexts and add crash test#41092
jdm merged 2 commits intoservo:mainfrom
Taym95:mediaelement-audio-inert-check

Conversation

@Taym95
Copy link
Copy Markdown
Member

@Taym95 Taym95 commented Dec 5, 2025

Guard MediaElementAudioSourceNode against closed contexts and add crash test

Testing: Added crash test.
Fixes: #41083

@Taym95 Taym95 requested a review from gterzian as a code owner December 5, 2025 23:07
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 5, 2025
@Taym95 Taym95 requested a review from jdm December 5, 2025 23:07
@Taym95 Taym95 force-pushed the mediaelement-audio-inert-check branch from 0c102e3 to 91ec290 Compare December 5, 2025 23:24
@servo-highfive servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Dec 6, 2025
…ests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSource_closed_context-crash.html

Signed-off-by: Taym Haddadi <[email protected]>
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56550) with upstreamable changes.

@Taym95 Taym95 requested a review from jdm December 6, 2025 15:52
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56550).

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Dec 6, 2025
@jdm jdm added this pull request to the merge queue Dec 6, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 6, 2025
Merged via the queue into servo:main with commit d10d481 Dec 6, 2025
29 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: called Result::unwrap() on an Err value: RecvError (thread Script#1, at components/script/dom/audio/mediaelementaudiosourcenode.rs:48)

4 participants