script: Fix IIRFilter crash on silent blocks and add crash test#41091
script: Fix IIRFilter crash on silent blocks and add crash test#41091jdm merged 1 commit intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#19978244364) for Linux (WPT) |
864c4c7 to
3de4712
Compare
.../tests/webaudio/the-audio-api/the-iirfilternode-interface/iir-filter-silent-block-crash.html
Show resolved
Hide resolved
3de4712 to
23ad2a5
Compare
|
Test results for linux-wpt from try job (#19978244364): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (19)
|
|
✨ Try run (#19978244364) succeeded. |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56542) with upstreamable changes. |
23ad2a5 to
c4869e3
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56542). |
|
🔨 Triggering try run (#19991318796) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19991318796): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (22)
|
|
✨ Try run (#19991318796) succeeded. |
c4869e3 to
4e099f7
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56542). |
|
@Taym95 Do you mind explaining what was wrong and what the fix did to fix this in the PR title and description before landing? Thanks. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56542) title and body. |
1 similar comment
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56542) title and body. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56542) title and body. |
Signed-off-by: Taym Haddadi <[email protected]>
4e099f7 to
c3375a5
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56542). |
|
🔨 Triggering try run (#19994237204) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19994237204): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#19994237204) succeeded. |
Fix IIRFilter crash on silent blocks and add crash test.
Before fix:
let blocks: SmallVec<[Block; 1]> = SmallVec::new();followed byblocks.as_slice().iter().map(.), Because blocks was empty, the iterator never produced anything, so the resulting Chunk had zero blocks and caused:Now: we still use SmallVec<[Block; 1]>, but we actually push a block into it before returning: create Block::default(), call explicit_silence() on it, blocks.push(block), then Chunk { blocks }. This ensures the chunk contains one explicit silent block, which is what downstream code expects.
Actual fix is in:
servo/media#477
This PR uses the new media version containing fix and added crash test.
Testing: added crash test.
Fixes: #41085