Merged
Conversation
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Dec 5, 2025
servo-highfive
removed
the
S-awaiting-review
eerii
force-pushed
the
devtools-firefox-145
branch
from
2dba975 to
ad68f05
Compare
servo-highfive
added
the
S-awaiting-review
nicoburns
reviewed
Dec 8, 2025
eerii
force-pushed
the
devtools-firefox-145
branch
from
ad68f05 to
3f1df18
Compare
nicoburns
approved these changes
Dec 8, 2025
servo-highfive
removed
the
S-awaiting-review
The performance actor is now called "perf". Refactor the handling of global actors in the root actor. Root actor now registers the necessary actors when it is created. Signed-off-by: eri <[email protected]>
eerii
force-pushed
the
devtools-firefox-145
branch
from
3f1df18 to
f660506
Compare
servo-highfive
added
the
S-awaiting-review
Member
Author
|
Rebased it on main because of a few collisions with the |
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
Update the target spec version from 133 to 145. Solves a few issues with incorrect or outdated messages, such as an error with `reflow`. The only meaningful change I could find is that the performance actor is now called "perf" instead of "performance". It is part of a set of global actors that the root handles. I made it more explicit and moved the global actor registration inside of the root actor, it makes more sense to have it there. Finally, I ordered the message handling alphabetically. The only changed entry is `getRoot` because of the global actors. Testing: I manually tested the functionalities and checked the logs. Signed-off-by: eri <[email protected]>
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the target spec version from 133 to 145. Solves a few issues with incorrect or outdated messages, such as an error with
reflow.The only meaningful change I could find is that the performance actor is now called "perf" instead of "performance". It is part of a set of global actors that the root handles. I made it more explicit and moved the global actor registration inside of the root actor, it makes more sense to have it there.
Finally, I ordered the message handling alphabetically. The only changed entry is
getRootbecause of the global actors.Testing: I manually tested the functionalities and checked the logs.