mach: Add yes installation cofirmation flag to bootstrap command#41086
Merged
mrobinson merged 4 commits intoservo:mainfrom Dec 8, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
Signed-off-by: MCozhusheck <[email protected]>
MCozhusheck
force-pushed
the
feature/mach-bootstrap-non-interactive-option
branch
from
950e2fc to
ec048c7
Compare
mrobinson
requested changes
Dec 5, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
I wonder if we should just always use the -y behavior, but this seems okay for the moment. I have one small suggestion.
servo-highfive
added
S-needs-code-changes
Signed-off-by: MCozhusheck <[email protected]>
MCozhusheck
force-pushed
the
feature/mach-bootstrap-non-interactive-option
branch
from
90881a4 to
e469237
Compare
Collaborator
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
mrobinson
changed the title
mrobinson
approved these changes
Dec 8, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #40502
Adds
--yesflag to mach bootstrap command which confirms installation of all required packages.Unlike
--forceflag (which also does that) it does NOT reinstall all packages but only confirms them (if required at all).Test on Ubuntu 24.04.2 LTS by removing safe development packages like
libgstrtspserver-1.0-dev libges-1.0-dev gstreamer1.0-toolsand runmach bootstraptwice to observe if--yesflags automatically install all dependencies.With this flag all dependencies were installed with any interaction but removing some dependencies and running
./mach bootstrapprompted me to confirmapt-get installaction.