ohos / android: Fix missing error message for cli parsing errors#41072
Merged
jschwe merged 6 commits intoservo:mainfrom Dec 8, 2025
Merged
ohos / android: Fix missing error message for cli parsing errors#41072jschwe merged 6 commits intoservo:mainfrom
jschwe merged 6 commits intoservo:mainfrom
Conversation
Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Narfinger <[email protected]>
jschwe
reviewed
Dec 5, 2025
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
jschwe
reviewed
Dec 6, 2025
jschwe
reviewed
Dec 6, 2025
jschwe
reviewed
Dec 6, 2025
jschwe
changed the title
Signed-off-by: Narfinger <[email protected]>
jschwe
reviewed
Dec 8, 2025
jschwe
approved these changes
Dec 8, 2025
Member
jschwe
left a comment
jschwe
left a comment
There was a problem hiding this comment.
LGTM, just left a final comment / nit
servo-highfive
removed
the
S-awaiting-review
Co-authored-by: Jonathan Schwender <[email protected]> Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ohos/android the early redirect from stderr/stdout is not yet setup when we parse commandline arguments.
This redirects these error on the standard logging facilities.
Testing: Tested on OHOS device with correct and incorrect arguments and on linux desktop.