Devtools: Switch to GenericChannel and GenericCallback#41051
Merged
yezhizhen merged 2 commits intoservo:mainfrom Dec 8, 2025
Merged
Devtools: Switch to GenericChannel and GenericCallback#41051yezhizhen merged 2 commits intoservo:mainfrom
yezhizhen merged 2 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Dec 6, 2025
servo-highfive
added
S-needs-rebase
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Narfinger
force-pushed
the
devtools-generic-sender
branch
from
c5fa0a0 to
c28fe45
Compare
servo-highfive
added
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
Switch the devtools part to GenericCallback and GenericSender. To keep the diff small the names where not changes as a Sender almost fills the same requirement as a callback. Testing: As this is mostly type changes, the compilation is the test but also devtools seem to work fine with these changes. ./mach try run is here: https://github.com/Narfinger/servo/actions/runs/19931697694 --------- Signed-off-by: Narfinger <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the devtools part to GenericCallback and GenericSender.
To keep the diff small the names where not changes as a Sender almost fills the same requirement as a callback.
Testing: As this is mostly type changes, the compilation is the test but also devtools seem to work fine with these changes. ./mach try run is here: https://github.com/Narfinger/servo/actions/runs/19931697694