Skip to content

change some allows to expects#41040

Merged
jschwe merged 1 commit intoservo:mainfrom
AnonMiraj:change-allow-to-expect
Dec 5, 2025
Merged

change some allows to expects#41040
jschwe merged 1 commit intoservo:mainfrom
AnonMiraj:change-allow-to-expect

Conversation

@AnonMiraj
Copy link
Copy Markdown
Contributor

@AnonMiraj AnonMiraj commented Dec 4, 2025

Changed some allow to expects and removed the unfulfilled expectations.

Testing: Refactor
Part of: #40383

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 4, 2025
jdm
jdm approved these changes Dec 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Dec 4, 2025
@jdm
Copy link
Copy Markdown
Member

jdm commented Dec 4, 2025

You will need to sign your commit, however. You can use git commit --amend -s for that.

@jdm jdm added the S-needs-code-changes Changes have not yet been made that were requested by a reviewer. label Dec 4, 2025
@AnonMiraj AnonMiraj force-pushed the change-allow-to-expect branch from 834b956 to 0e18b83 Compare December 4, 2025 06:10
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Dec 4, 2025
jschwe
jschwe requested changes Dec 4, 2025
View reviewed changes
@servo-highfive servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 4, 2025
@AnonMiraj AnonMiraj force-pushed the change-allow-to-expect branch from 0e18b83 to 2e927f3 Compare December 4, 2025 06:22
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Dec 4, 2025
@AnonMiraj AnonMiraj force-pushed the change-allow-to-expect branch from 2e927f3 to 51cb7fe Compare December 4, 2025 07:15
jschwe
jschwe reviewed Dec 4, 2025
View reviewed changes
@AnonMiraj AnonMiraj force-pushed the change-allow-to-expect branch from 51cb7fe to 76b7fe6 Compare December 4, 2025 15:22
@AnonMiraj AnonMiraj force-pushed the change-allow-to-expect branch from 76b7fe6 to 7d258dc Compare December 5, 2025 02:52
@AnonMiraj AnonMiraj requested a review from jschwe December 5, 2025 03:19
jschwe
jschwe approved these changes Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jschwe jschwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Dec 5, 2025
@jschwe jschwe added this pull request to the merge queue Dec 5, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 5, 2025
Merged via the queue into servo:main with commit b207be0 Dec 5, 2025
29 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdm jdm jdm approved these changes

@jschwe jschwe jschwe approved these changes

@sagudev sagudev Awaiting requested review from sagudev sagudev is a code owner

@yezhizhen yezhizhen Awaiting requested review from yezhizhen yezhizhen is a code owner

@atbrakhi atbrakhi Awaiting requested review from atbrakhi atbrakhi is a code owner

@nicoburns nicoburns Awaiting requested review from nicoburns nicoburns is a code owner

@mrobinson mrobinson Awaiting requested review from mrobinson mrobinson is a code owner

@Loirooriol Loirooriol Awaiting requested review from Loirooriol Loirooriol is a code owner

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AnonMiraj @jdm @jschwe @servo-highfive