Merged
Conversation
Signed-off-by: César Pedraza <[email protected]>
servo-highfive
added
the
S-awaiting-review
Member
|
@kkoyung Want to review this? |
Member
Sure! |
servo-highfive
added
S-needs-code-changes
Signed-off-by: César Pedraza <[email protected]>
servo-highfive
added
S-awaiting-review
kkoyung
approved these changes
Dec 4, 2025
Member
kkoyung
left a comment
kkoyung
left a comment
There was a problem hiding this comment.
Thanks!
I'm thinking on adding more messages, so any feedback would be appreciated! :)
In the WebCrypto code (most of which is in components/script/dom/subtlecrypto/), there are a lot of steps that are "If XXX, then throw an YYYError", making it easy to write the error message for them. You can check it out.
Other parts in our codebase are missing many error messages too. Contribution to them are also welcome.
servo-highfive
removed
the
S-awaiting-review
jdm
approved these changes
Dec 5, 2025
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script: add error messages for conditions in
encrypt_aes_ctrTesting: No tests needed (?) let me know if I should add tests for this somewhere.
Fixes: #40756
Followed the MDN and w3c docs to write the messages.
I'm thinking on adding more messages, so any feedback would be appreciated! :)