Merged
Conversation
On Linux thread names are limited to 15 characters: that caused all the script
threads to be named 'ScriptScriptEve' and show up with the same name in tooling.
That changes turns the name to 'Script#{script id}' instead.
Signed-off-by: webbeef <[email protected]>
servo-highfive
added
the
S-awaiting-review
jschwe
approved these changes
Dec 3, 2025
Member
jschwe
left a comment
jschwe
left a comment
There was a problem hiding this comment.
Personally I'm fine with this, but perhaps it would be best to announce on zulip, since perhaps people might have scripts which would need to be updated if the thread name changes (benchmark / profiling related)
servo-highfive
removed
the
S-awaiting-review
Contributor
Author
The thread name used to be short, but was changed recently in 08aad55 . I noticed it when doing profiling, so that mostly revert to previous state. |
Member
|
Thanks for clarifying! |
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux thread names are limited to 15 characters: that caused all the script threads to be named 'ScriptScriptEve' and show up with the same name in tooling.
That changes turns the name to 'Script#{script id}' instead.
Testing: No test coverage for that very internal detail.