IndexedDB: Use GenericSender, GenericReceiver and GenericCallback for IndexedDB#41031
Merged
jdm merged 2 commits intoservo:mainfrom Dec 4, 2025
Merged
IndexedDB: Use GenericSender, GenericReceiver and GenericCallback for IndexedDB#41031jdm merged 2 commits intoservo:mainfrom
jdm merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-review
Narfinger
changed the title
|
Signed-off-by: Narfinger <[email protected]>
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving IndexedDB to use the generic channel methods.
Of note is the change in 'IDBRequest::execute_async'. This method previously added a channel that was constructed from the callsite in put into the AsyncOperation. Now we do not take a function but take a 'FnOnce(GenericCallback<BackendResult>) -> AsyncOperation'. With this the callsite can construct the AsyncOperation to give in the 'IndexedDBThreadMsg::Async'.
The rest are mostly just type changes.
Signed-off-by: Narfinger [email protected]
Testing: WPT tests on the IndexedDB subset still pass.