html: Change the play state of the media player if the old is opposite#41027
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Dec 4, 2025
Merged
html: Change the play state of the media player if the old is opposite#41027TimvdLippe merged 1 commit intoservo:mainfrom
play state of the media player if the old is opposite#41027TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
7f5f216 to
714a082
Compare
|
🔨 Triggering try run (#19887368576) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19887368576): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#19887368576) succeeded. |
TimvdLippe
approved these changes
Dec 3, 2025
Contributor
TimvdLippe
left a comment
There was a problem hiding this comment.
Changes look fine to me, but the actual review is probably in the media crate. I will leave that up to others as they are more knowledgeable of that area.
714a082 to
30979ba
Compare
It's important to check the media player's `paused` state to avoid unnecessary changes to its internal state (via `play`, `pause`), including configuration the `playback rate` and `volume` properties. Depends on servo/media#467 Testing: The expected test results are unchanged because it is the implicit performance improvements of the media stack, with the exception of the following test, which is affected by the `playback rate` state caching mechanism (the `seek` position is not overridden for default playback rate (1.0)). - html/semantics/embedded-content/media-elements/preserves-pitch.html See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4762 Signed-off-by: Andrei Volykhin <[email protected]>
30979ba to
236cf25
Compare
|
🔨 Triggering try run (#19926388248) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19926388248): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (25)
|
|
✨ Try run (#19926388248) succeeded. |
TimvdLippe
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's important to check the media player's
pausedstate to avoid unnecessary changes to its internal state (viaplay,pause), including configuration theplayback rateandvolumeproperties.Depends on servo/media#467
Testing: The expected test results are unchanged because it is the implicit performance improvements of the media stack, with the exception of the following test, which is affected by the
playback ratestate caching mechanism (theseekposition is not overridden for default playback rate (1.0)).See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4762