libservo: Trigger shutdown internally from Servo's Drop impl#41012
Merged
mukilan merged 1 commit intoservo:mainfrom Dec 3, 2025
Merged
libservo: Trigger shutdown internally from Servo's Drop impl#41012mukilan merged 1 commit intoservo:mainfrom
Servo's Drop impl#41012mukilan merged 1 commit intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#19860729458) for Android, OpenHarmony |
|
✨ Try run (#19860729458) succeeded. |
|
🔨 Triggering try run (#19878452147) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19878452147): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (21)
|
|
✨ Try run (#19878452147) succeeded. |
yezhizhen
reviewed
Dec 3, 2025
Member
yezhizhen
left a comment
There was a problem hiding this comment.
I checked the log: #41012 (comment)
I'm glad this doesn't trigger #40972 again.
Remove the public API to trigger shutdown and instead trigger the process from `Servo`'s implementation of `Drop` trait. This makes it hard to create issues involving the order of destruction of `Servo` and `WebView`s. It will also allow us to implement asynchronous shutdown in the future. Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Mukilan Thiyagarajan <[email protected]>
3e2cca8 to
43401e1
Compare
mrobinson
approved these changes
Dec 3, 2025
Servo's Drop impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the public API to trigger shutdown and instead trigger the process from
Servo's implementation ofDroptrait.This makes it hard to create issues involving the order of destruction of
ServoandWebViews. It will also allow us to implement asynchronous shutdown in the future.Testing: Should be covered by existing unit tests.