libservo: Make Servo an opaque cloneable handle#41010
Merged
mukilan merged 1 commit intoservo:mainfrom Dec 2, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Dec 2, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Looks good with one minor change:
servo-highfive
removed
the
S-awaiting-review
Move the members of `Servo` struct to an inner structure that is wrapped in an `Rc` so that handle to `Servo` instances can be made cloneable and used from `WebView`s. Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Mukilan Thiyagarajan <[email protected]>
mukilan
force-pushed
the
servo-cloneable-handle
branch
from
73347ab to
9fc1df9
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the members of
Servostruct to an inner structure that is wrapped in anRcso that handle toServoinstances can be made cloneable and used fromWebViews.Testing: This preserves existing public API of the Servo struct, so should be covered by existing tests.