Skip to content

webdriver: Refactor actions.rs#41004

Merged
yezhizhen merged 2 commits intoservo:mainfrom
yezhizhen:rush
Dec 2, 2025
Merged

webdriver: Refactor actions.rs#41004
yezhizhen merged 2 commits intoservo:mainfrom
yezhizhen:rush

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Dec 2, 2025

  • Remove some unnecessary loop, cloning.
  • Simplify some match
  • Explicitly state unused match arm: PointerCancel is not implemented.

Testing: Refactor. Covered by existing test.

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 2, 2025
@yezhizhen yezhizhen force-pushed the rush branch 2 times, most recently from d3b1371 to 83ef436 Compare December 2, 2025 08:17
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Dec 2, 2025
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 2, 2025
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen added this pull request to the merge queue Dec 2, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 2, 2025
@yezhizhen yezhizhen added this pull request to the merge queue Dec 2, 2025
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 2, 2025
Merged via the queue into servo:main with commit d7e1395 Dec 2, 2025
35 checks passed
@yezhizhen yezhizhen deleted the rush branch December 2, 2025 13:45
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants