script: Reconstruct box tree when `order` changes by Loirooriol · Pull Request #40994 · servo/servo

Loirooriol · 2025-12-01T23:32:01Z

The CSS order property affects the order of boxes in the box tree. Therefore, when it changes, we need to reconstruct it.

Testing: Adding new test
Fixes: #40813

The CSS `order` property affects the order of boxes in the box tree. Therefore, when it changes, we need to reconstruct it. Signed-off-by: Oriol Brufau <[email protected]>

github-actions · 2025-12-01T23:32:18Z

🔨 Triggering try run (#19841096218) for Linux (WPT)

servo-wpt-sync · 2025-12-01T23:35:04Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56391) with upstreamable changes.

github-actions · 2025-12-02T00:01:47Z

Test results for linux-wpt from try job (#19841096218):

Flaky unexpected result (37)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```

OK /_mozilla/webxr/obtain_frame.https.html

FAIL [expected PASS] subtest: obtain_frame

promise_test: Unhandled rejection with value: object "TypeError: can't access property "simulateDeviceConnection", navigator.xr.test is undefined"

ERROR [expected TIMEOUT] /_mozilla/webxr/sessionavailable.https.html
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 14 more unexpected results...
TIMEOUT [expected OK] /content-security-policy/inheritance/document-write-iframe.html
- TIMEOUT [expected PASS] subtest: document.open() keeps inherited CSPs on transient about:blank.
```
Test timed out
```
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Single value - Non-empty name exists
- PASS [expected FAIL] subtest: Multiple values - name content attribute is ignored
OK /fetch/content-length/api-and-duplicate-headers.any.html (#35873)
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /fetch/metadata/window-open.https.sub.html (#40339)
- FAIL [expected PASS] subtest: Cross-site window, forced, reloaded
```
The operation is insecure.
```
CRASH [expected OK] /html/anonymous-iframe/embedding.tentative.https.window.html?12-12
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
CRASH [expected OK] /html/browsers/the-window-object/window-open-noopener.html?_top
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
OK /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- FAIL [expected PASS] subtest: Speed-ups should not change the pitch when preservesPitch=true
```
assert_approx_equals: The actual pitch should be close to the expected pitch. expected 440 +/- 66 but got 0
```
CRASH [expected OK] /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event)
```
assert_equals: expected "basic=test\r\n" but got ""
```
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: Basic File test (formdata event)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (formdata event)
```
assert_equals: expected "basic=test" but got ""
```
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: single quote in name (normal form)

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

CRASH [expected OK] /html/webappapis/timers/type-long-settimeout.any.html
OK /preload/preload-invalid-resources.html (#39091)
- PASS [expected FAIL] subtest: Preloading an invalid image (invalid data) should preload and not re-fetch
TIMEOUT [expected OK] /referrer-policy/css-integration/svg/internal-stylesheet.html
- TIMEOUT [expected FAIL] subtest: Styling SVG from internal styles filter
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Styling SVG from internal styles clip-path
- NOTRUN [expected FAIL] subtest: Styling SVG from internal styles marker-start
- NOTRUN [expected FAIL] subtest: Styling SVG from internal styles marker-mid
- NOTRUN [expected FAIL] subtest: Styling SVG from internal styles marker-end
- NOTRUN [expected FAIL] subtest: Styling SVG from internal styles mask
- NOTRUN [expected FAIL] subtest: Styling SVG from internal styles mask-image
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- PASS [expected FAIL] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
CRASH [expected OK] /trusted-types/Element-setAttribute-setAttributeNS-sinks.tentative.html
CRASH [expected OK] /trusted-types/should-trusted-type-policy-creation-be-blocked-by-csp-003.html
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
CRASH [expected OK] /uievents/idlharness.window.html
CRASH [expected ERROR] /wasm/webapi/empty-body.any.serviceworker.html
CRASH [expected OK] /webaudio/the-audio-api/the-audiobuffersourcenode-interface/note-grain-on-timing.html
TIMEOUT [expected OK] /webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html (#22425)
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (18)

OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- FAIL [expected PASS] subtest: location.reload() of empty iframe.
```
assert_equals: Image should be blocked by CSP after reload. expected "img blocked" but got "img loaded"
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 1
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-monospace (drawing text in a canvas)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-mode
- PASS [expected FAIL] subtest: sec-fetch-dest
- PASS [expected FAIL] subtest: sec-fetch-user
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Cross-site
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected PASS] subtest: sec-fetch-site - Same site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Cross-Site -> Same-Origin redirect, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Same-Site -> Same-Origin redirect, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Same Origin, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Same-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - attributes: crossorigin
- FAIL [expected PASS] subtest: sec-fetch-mode - attributes: crossorigin=anonymous
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-mode - attributes: crossorigin=use-credentials
- PASS [expected FAIL] subtest: sec-fetch-user - no attributes
- And 1 more unexpected results...
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
ERROR [expected OK] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- TIMEOUT [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: 404 (fetch): main
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.

github-actions · 2025-12-02T00:01:54Z

✨ Try run (#19841096218) succeeded.

script: Reconstruct box tree when order changes

41564f6

The CSS `order` property affects the order of boxes in the box tree. Therefore, when it changes, we need to reconstruct it. Signed-off-by: Oriol Brufau <[email protected]>

Loirooriol added A-content/script Related to the script thread A-layout/incremental T-linux-wpt Do a try run of the WPT labels Dec 1, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Dec 1, 2025

servo-wpt-sync mentioned this pull request Dec 1, 2025

script: Reconstruct box tree when order changes web-platform-tests/wpt#56391

Merged

Loirooriol marked this pull request as ready for review December 2, 2025 00:24

Loirooriol requested a review from gterzian as a code owner December 2, 2025 00:24

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 2, 2025

Loirooriol enabled auto-merge December 2, 2025 00:24

Loirooriol requested a review from mrobinson December 2, 2025 00:24

mrobinson approved these changes Dec 2, 2025

View reviewed changes

Loirooriol added this pull request to the merge queue Dec 2, 2025

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 2, 2025

Merged via the queue into servo:main with commit 2fdc18c Dec 2, 2025
73 of 74 checks passed

Loirooriol deleted the order-rebuild-box-tree branch December 2, 2025 09:28

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Reconstruct box tree when `order` changes#40994

script: Reconstruct box tree when `order` changes#40994
Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol:order-rebuild-box-tree

Loirooriol commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

servo-wpt-sync commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Loirooriol commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

servo-wpt-sync commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants