ci: Update condition to upload test results to codecov#40988
Merged
jschwe merged 1 commit intoservo:mainfrom Dec 2, 2025
Merged
ci: Update condition to upload test results to codecov#40988jschwe merged 1 commit intoservo:mainfrom
jschwe merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
sagudev
approved these changes
Dec 1, 2025
.github/workflows/linux.yml
Outdated
| # Upload test results to Codecov, also for failed unit-tests, but only | ||
| # if unit-tests were supposed to run, and not if they were skipped (e.g. due to | ||
| # an earlier failure). | ||
| if: ${{ !cancelled() && inputs.unit-tests && steps.run_unit_tests.conclusion != 'skipped' }} |
Member
There was a problem hiding this comment.
I suspect the last condition is enough.
Member
Author
There was a problem hiding this comment.
Yeah, the second condition should be covered by the last one. I'll keep the first condition though, since a job could get cancelled while running the tests, and in such a case we wouldn't want to upload results.
servo-highfive
removed
the
S-awaiting-review
This should fix comments about missing junit.xml files, when the CI job failed before executing the unit-tests. Signed-off-by: Jonathan Schwender <[email protected]>
jschwe
force-pushed
the
jschwender/codecov-fix
branch
from
e7b738d to
16a836a
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
This should fix comments about missing junit.xml files, when the CI job failed before executing the unit-tests. Testing: Not tested, this is essentially a speculative fix. Not sure how to test it. Fixes: #40985 Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
removed
the
S-awaiting-merge
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix comments about missing junit.xml files, when the CI job failed before executing the unit-tests.
Testing: Not tested, this is essentially a speculative fix. Not sure how to test it.
Fixes: #40985