libservo: Clean up Servo exports and export more at the root#40951
Merged
mrobinson merged 1 commit intoservo:mainfrom Nov 29, 2025
Merged
libservo: Clean up Servo exports and export more at the root#40951mrobinson merged 1 commit intoservo:mainfrom
mrobinson merged 1 commit intoservo:mainfrom
Conversation
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
55a121e to
c3d43e3
Compare
|
🔨 Triggering try run (#19782896398) for OpenHarmony |
Bencher Report
servo-highfive
added
the
S-awaiting-review
Member
Author
|
This one is ready for review. |
|
|
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
c3d43e3 to
719dc41
Compare
|
🔨 Triggering try run (#19783210541) for OpenHarmony |
|
✨ Try run (#19783210541) succeeded. |
Taym95
approved these changes
Nov 29, 2025
servo-highfive
removed
the
S-awaiting-review
yezhizhen
approved these changes
Nov 29, 2025
Comment on lines
-7
to
-9
| //! This is a very simple library that wires all of Servo's components | ||
| //! together as type `Servo`, along with a generic client | ||
| //! implementing the `WindowMethods` trait, to create a working web |
Member
There was a problem hiding this comment.
None of texts are actually changed. The blame might look bad.
But some texts below are actually changed.
Member
Author
There was a problem hiding this comment.
Yes. I have also removed some out of date information here, which I forgot to mention in the description of the PR. All of the documentation for the API needs a lot of work.
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
719dc41 to
f79c2aa
Compare
servo-highfive
added
S-awaiting-review
mrobinson
added
S-tests-failed
|
🔨 Triggering try run (#19786191511) for Windows |
|
|
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
f79c2aa to
4492c9a
Compare
servo-highfive
added
S-awaiting-review
|
🔨 Triggering try run (#19786309566) for Windows |
|
✨ Try run (#19786309566) succeeded. |
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
This change makes it easier for embedders to embed the types that they need by exporting almost everything necessary to use Servo at the root of libservo, apart from a few exceptions. In addition, the `Servo` is moved to its own file so that public exports can be more easily spotted from `components/servo/lib.rs`. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
clean-up-servo-exports
branch
from
4492c9a to
96b42b9
Compare
servo-highfive
removed
the
S-tests-failed
|
🔨 Triggering try run (#19786716293) for Android |
|
✨ Try run (#19786716293) succeeded. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it easier for embedders to embed the types that they
need by exporting almost everything necessary to use Servo at the root
of libservo, apart from a few exceptions. In addition, the
Servois movedto its own file so that public exports can be more easily spotted from
components/servo/lib.rs.Testing: This should not change behavior and is thus covered by existing tests.
Fixes: #18475.