constellation: Break the `EventLoop` dependency on the initial `Pipeline` by mrobinson · Pull Request #40944 · servo/servo

mrobinson · 2025-11-28T16:44:59Z

Currently starting a script EventLoop depends on sending data about
the initial Pipeline. This change breaks this dependency. The goal
here is to:

Allow ScriptThreads to be shared between WebViews. This will
allow more flexiblity with the way that ScriptThreads are created,
which should allow us to perserve system resources by allowing them
to be shared between WebViews. With this change, we can do away
with the InitialPipelineState entirely, which was gather
information necessary for both a new EventLoop and a new
Pipeline. We no longer have to do many clones when reusing an
existing even loop.
Simplify the way that EventLoops and Pipelines are spawned. Now
Pipelines are spawned in the same way no matter what.

Now the general order of operations when starting a pipeline is:

Get or create an event loop for the pipeline:
- If the event loop needs to be spawn, spawned it in a new thread or
  process.
Send the spawn pipeline message to the event loop (kept alive via an
Rc.

Testing: This should not change behavior in a way that is observable, so should
be covered by existing tests.

github-actions · 2025-11-28T17:08:17Z

🔨 Triggering try run (#19770036238) for Linux (WPT)

github-actions · 2025-11-28T17:44:35Z

⚠️ Try run (#19770036238) failed.

components/constellation/constellation.rs

jdm · 2025-11-29T06:16:38Z

components/constellation/constellation.rs

+
+        let event_loop = EventLoop::spawn(self, is_private)?;
+        if let Some(registered_domain_name) = registered_domain_name {
+            self.set_event_loop(&event_loop, registered_domain_name, webview_id, opener);


If we spawn an event loop but don't have a registered domain name, won't the new event loop be dropped immediately after we return? That seems like we should return an error instead of spawning in that case.

Constellation::set_event_loop is only responsible for setting a Weak<EventLoop> on the BrowsingContextGroup so that it can be reused (if it's upgradeable in the future). What really keeps it alive here is the return value which should be valid until it is used when spawning the pipeline.

jdm · 2025-11-29T06:24:42Z

components/constellation/constellation.rs

+    pub(crate) namespace_ipc_sender: GenericSender<PipelineNamespaceRequest>,
+
+    /// A [`Vec`] of all [`EventLoop`]s that have been created for this [`Constellation`].
+    /// This will be cleaned up periodically. This stores weak references so that [`EventLoop`]s


Where does this cleanup happen?

Cleanup happens during the spin of the Constellation event loop here: https://github.com/mrobinson/servo/blob/7e11aff754449b4a888898aeef561ebac0356b41/components/constellation/constellation.rs#L782

I think that only cleans up the event_loop_join_handles, not event_loops.

Oh. I see. You are right. I'll address this.

github-actions · 2025-11-29T09:12:54Z

🔨 Triggering try run (#19781876818) for Linux (WPT)

github-actions · 2025-11-29T09:43:49Z

Test results for linux-wpt from try job (#19781876818):

Flaky unexpected result (39)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
PASS [expected FAIL] /_mozilla/css/linear_gradients_reverse_a.html
OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```

OK /_mozilla/webxr/obtain_frame.https.html

FAIL [expected PASS] subtest: obtain_frame

promise_test: Unhandled rejection with value: object "TypeError: can't access property "simulateDeviceConnection", navigator.xr.test is undefined"

CRASH [expected ERROR] /_webgl/conformance2/textures/misc/tex-input-validation.html (#38890)
TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- PASS [expected FAIL] subtest: location.reload() of empty iframe.
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Single value - Non-empty name exists
- PASS [expected FAIL] subtest: Newline normalization - \r\n in value (urlencoded)
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
ERROR [expected OK] /fullscreen/model/remove-last.html
CRASH [expected OK] /html/browsers/browsing-the-web/history-traversal/pagereveal/order-in-new-document-navigation.html
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: Basic test (formdata event)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"\r\n\r\ntest\r\n--\r\n" but got ""
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event)
```
assert_equals: expected "basic=test\r\n" but got ""
```
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: 0x00 in name (normal form)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (formdata event)
```
assert_equals: expected "basic=test" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
PASS [expected FAIL] /png/apng/acTL-plays-one.html
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: CORS (fetch): main
OK /preload/preload-xhr.html (#39092)
- FAIL [expected PASS] subtest: Make an XHR request immediately after creating link rel=preload.
```
assert_equals: resources/dummy.xml?token=73cea623-149d-40ed-81ac-7f1b9ef88dc2 expected 1 but got 0
```
CRASH [expected ERROR] /trusted-types/SharedWorker-setTimeout-setInterval.html
CRASH [expected OK] /trusted-types/block-string-assignment-to-DedicatedWorker-setTimeout-setInterval.html
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- TIMEOUT [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
CRASH [expected TIMEOUT] /wasm/webapi/invalid-code.any.worker.html

OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)

FAIL [expected PASS] subtest: buffer-stitching-2

assert_approx_equals: Stitched sine‑wave buffers at sample rate 43800 sample[21205] |0.721803605556488 - -0.42100346088409424| = 1.1428070664405823 &gt; 0.0038986 expected -0.42100346088409424 +/- 0.0038986 but got 0.721803605556488

CRASH [expected TIMEOUT] /webaudio/the-audio-api/the-audiocontext-interface/promise-methods-after-discard.html
OK /webdriver/tests/classic/execute_async_script/promise.py
- FAIL [expected PASS] subtest: test_promise_resolve
```
AssertionError: no such window (404): No such window
```
OK /webdriver/tests/classic/find_element_from_shadow_root/find.py
- FAIL [expected PASS] subtest: test_null_parameter_value
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/get_title/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404)
```
OK /webdriver/tests/classic/perform_actions/pointer_pen.py
- FAIL [expected PASS] subtest: test_null_response_value
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (25)

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(khmer-mul)
```
assert_equals: quoted generic(khmer-mul) matches  @font-face rule expected 50 but got 30
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 40 but got 125
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted sans-serif (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
- And 5 more unexpected results...
FAIL [expected PASS] /css/css-grid/grid-lanes/tentative/alignment/row-grid-lanes-align-self-003.html (#40833)
FAIL [expected PASS] /css/css-grid/grid-lanes/tentative/grid-placement/row-explicit-placement-004.html (#40834)
FAIL [expected PASS] /css/css-grid/masonry/tentative/subgrid/column/masonry-subgrid-002f.html (#40830)
OK /fetch/fetch-later/permissions-policy/deferred-fetch-allowed-by-permissions-policy.https.window.html (#40478)
- PASS [expected FAIL] subtest: Permissions policy header: "deferred-fetch=*" allows fetchLater() in the top-level document.
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-mode
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Cross-site
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- FAIL [expected PASS] subtest: sec-fetch-site - Same site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Cross-Site -> Same-Origin redirect, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Same-Site -> Same-Origin redirect, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Same Origin, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Cross-Site -> Same-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Same-Site, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Cross-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Same Origin, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Site -> Same-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- And 1 more unexpected results...
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-dest - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-user - Not sent to non-trustworthy cross-site destination, no attributes
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK [expected CRASH] /fetch/metadata/window-open.https.sub.html (#40339)
- PASS [expected TIMEOUT] subtest: Same-origin window, user-activated
- PASS [expected TIMEOUT] subtest: Same-site window, user-activated
- PASS [expected TIMEOUT] subtest: Cross-site window, user-activated
- FAIL [expected PASS] subtest: Same-site window, user-activated: sec-fetch-site
```
assert_equals: expected "same-site" but got "same-origin"
```
- FAIL [expected PASS] subtest: Cross-site window, user-activated: sec-fetch-site
```
assert_equals: expected "cross-site" but got "same-origin"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 5] length 2, got [6, 3, 3] length 3
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- TIMEOUT [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
OK /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- FAIL [expected PASS] subtest: The default playbackRate should not affect pitch, even with preservesPitch=false
```
assert_approx_equals: The actual pitch should be close to the expected pitch. expected 440 +/- 66 but got 0
```
- FAIL [expected PASS] subtest: Speed-ups should not change the pitch when preservesPitch=true
```
assert_approx_equals: The actual pitch should be close to the expected pitch. expected 440 +/- 66 but got 0
```
- FAIL [expected PASS] subtest: Slow-downs should not change the pitch when preservesPitch=true
```
assert_approx_equals: The actual pitch should be close to the expected pitch. expected 440 +/- 66 but got 0
```

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

CRASH [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#40418)
OK [expected ERROR] /resource-timing/cors-preflight.any.html (#28694)
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.

Stable unexpected results (6)

OK /content-security-policy/frame-ancestors/frame-ancestors-nested-cross-in-sandboxed-cross-url-block.html
- FAIL [expected PASS] subtest: A 'frame-ancestors' CSP directive with a URL value should compare against each frame's origin rather than URL, so a nested frame with a sandboxed parent frame should be blocked due to the parent having a unique origin.
```
assert_unreached: Inner IFrame msg: The IFrame should have been blocked (or cross-origin). It wasn't. Reached unreachable code
```
OK /content-security-policy/frame-ancestors/frame-ancestors-sandbox-same-origin-self.html
- FAIL [expected PASS] subtest: A 'frame-ancestors' CSP directive with a 'self' value should compare the child URL (self) against each parent's origin's URL rather then URL. When the ancestors are sandboxed, they never match.
```
assert_unreached: Inner IFrame msg: The IFrame should have been blocked (or cross-origin). It wasn't. Reached unreachable code
```

OK /html/dom/self-origin.sub.html

FAIL [expected PASS] subtest: blob: subframe origins

assert_equals: Should have the right location origin for blob: iframe expected (string) "http://web-platform.test:8000" but got (undefined) undefined

OK /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_ancestor-1.html
- FAIL [expected PASS] subtest: Check that sandboxed iframe can not navigate their ancestors
```
assert_equals: Should have the right message expected "can not navigate" but got "can navigate"
```
OK /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-grandchild-unsandboxed-inherit.tentative.sub.window.html
- FAIL [expected PASS] subtest: An unsandboxed grandchild inherits its parents ability to navigate top.
```
assert_equals: The navigation should succeed. expected true but got false
```
TIMEOUT /shadow-dom/declarative/declarative-shadow-dom-opt-in.html
- TIMEOUT [expected PASS] subtest: iframe with no sandbox allows declarative Shadow DOM
```
Test timed out
```

github-actions · 2025-11-29T09:43:57Z

⚠️ Try run (#19781876818) failed.

mrobinson · 2025-11-29T17:27:59Z

I sent this to the MQ by accident. It will need a merge conflict fixed once #40951 lands.

…ine` Currently starting a script `EventLoop` depends on sending data about the initial `Pipeline`. This change breaks this dependency. The goal here is to: 1. Allow `ScriptThread`s to be shared between `WebView`s. This will allow more flexiblity with the way that `ScriptThread`s are created, which should allow us to perserve system resources by allowing them to be shared between `WebView`s. With this change, we can do away with the `InitialPipelineState` entirely, which was gather information necessary for both a new `EventLoop` and a new `Pipeline`. We no longer have to do many clones when reusing an existing even loop. 1. Simplify the way that `EventLoop`s and `Pipeline`s are spawned. Now `Pipeline`s are spawned in the same way no matter what. Now the general order of operations when starting a pipeline is: 1. Get or create an event loop for the pipeline: - If the event loop needs to be spawn, spawned it in a new thread or process. 2. Send the spawn pipeline message to the event loop (kept alive via an `Rc`. Signed-off-by: Martin Robinson <[email protected]>

I inadvertently left this debugging code in before landing the change. Signed-off-by: Martin Robinson <[email protected]>

I inadvertently left this debugging code in before landing the change. Testing: This just removes an unexpected `println!` so no new tests are necessary. Signed-off-by: Martin Robinson <[email protected]>

mrobinson requested a review from gterzian as a code owner November 28, 2025 16:45

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 28, 2025

mrobinson added the T-linux-wpt Do a try run of the WPT label Nov 28, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 28, 2025

jdm approved these changes Nov 29, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 29, 2025

jdm added the S-needs-code-changes Changes have not yet been made that were requested by a reviewer. label Nov 29, 2025

mrobinson force-pushed the break-pipline-dependency-in-constellation branch from 1caa3dc to 7e11aff Compare November 29, 2025 09:12

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 29, 2025

mrobinson added the T-linux-wpt Do a try run of the WPT label Nov 29, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 29, 2025

mrobinson force-pushed the break-pipline-dependency-in-constellation branch from 7e11aff to e25b829 Compare November 29, 2025 11:06

mrobinson enabled auto-merge November 29, 2025 11:06

mrobinson added this pull request to the merge queue Nov 29, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 29, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2025

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 29, 2025

mrobinson force-pushed the break-pipline-dependency-in-constellation branch from e25b829 to 78c87e5 Compare November 29, 2025 16:16

servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Nov 29, 2025

mrobinson added this pull request to the merge queue Nov 29, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 29, 2025

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 29, 2025

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 29, 2025

mrobinson force-pushed the break-pipline-dependency-in-constellation branch from 78c87e5 to 77c90b4 Compare November 29, 2025 23:07

mrobinson added this pull request to the merge queue Nov 29, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 29, 2025

Merged via the queue into servo:main with commit 2503684 Nov 30, 2025
29 checks passed

mrobinson deleted the break-pipline-dependency-in-constellation branch November 30, 2025 00:03

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 30, 2025

mrobinson added a commit to mrobinson/servo that referenced this pull request Dec 2, 2025

constellation: Remove debugging println! introduced in servo#40944

55f6866

I inadvertently left this debugging code in before landing the change. Signed-off-by: Martin Robinson <[email protected]>

Uh oh!

Conversation

mrobinson commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

Uh oh!

jdm Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

mrobinson Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

jdm Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

mrobinson Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

jdm Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

mrobinson Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 29, 2025

Uh oh!

github-actions bot commented Nov 29, 2025

Uh oh!

github-actions bot commented Nov 29, 2025

Uh oh!

Uh oh!

mrobinson commented Nov 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants