servoshell: Schedule keyboard shortcut exits so that they can be done cleanly#40933
Merged
mrobinson merged 1 commit intoservo:mainfrom Nov 28, 2025
Merged
Conversation
… cleanly This is a speculative fix for a crash mentioned by @mukilan[^1]. It will also make moving to a more consistent shutdown model (even one driven by dropping of the `Servo` instance) possible. [^1]: servo#40883 (comment) Signed-off-by: Martin Robinson <[email protected]>
servo-highfive
added
the
S-awaiting-review
mukilan
approved these changes
Nov 28, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a speculative fix for a crash mentioned by @mukilan1. It will
also make moving to a more consistent shutdown model (even one driven by
dropping of the
Servoinstance) possible.Testing: It's difficult to test this crash because it seems to only happen on
nixOS and we currently don't have a good way to test crashes on exit.
Footnotes
https://github.com/servo/servo/pull/40883#issuecomment-3584090609 ↩