servoshell: Add support for opening new windows on desktop#40927
Merged
mrobinson merged 1 commit intoservo:mainfrom Dec 2, 2025
Merged
servoshell: Add support for opening new windows on desktop#40927mrobinson merged 1 commit intoservo:mainfrom
mrobinson merged 1 commit intoservo:mainfrom
Conversation
mrobinson
force-pushed
the
servoshell-add-multi-window
branch
from
ee6cc41 to
a4bd3e3
Compare
6 tasks
mrobinson
force-pushed
the
servoshell-add-multi-window
branch
from
a4bd3e3 to
a296bf8
Compare
servo-highfive
added
the
S-awaiting-review
Member
Author
|
This one is now ready for review. |
mrobinson
changed the title
mrobinson
force-pushed
the
servoshell-add-multi-window
branch
from
a296bf8 to
3c6d83b
Compare
mukilan
approved these changes
Dec 2, 2025
Member
mukilan
left a comment
mukilan
left a comment
There was a problem hiding this comment.
I found an issue during testing - the 'experminental features' button only gets activated in the window where it is clicked. I guess this is because each Gui has its own state but the preferences are set globally.
servo-highfive
removed
the
S-awaiting-review
mrobinson
force-pushed
the
servoshell-add-multi-window
branch
from
3c6d83b to
927875a
Compare
servo-highfive
added
the
S-awaiting-review
Member
Author
Thanks for pointing this out. I've addressed it. |
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
This change finishes adding support for opening new windows in the desktop version of servoshell. A new button is added to the tab bar which opens a new window (this can be adjusted later, if necessary). User interface commands now need to be processed in the context of the `App` as we need access to a reference to the `ActiveEventLoop` to create a new window. Fixes servo#13997. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
servoshell-add-multi-window
branch
from
927875a to
f78a91a
Compare
servo-highfive
removed
the
S-tests-failed
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change finishes adding support for opening new windows in the
desktop version of servoshell. A new button is added to the tab bar
which opens a new window (this can be adjusted later, if necessary).
User interface commands now need to be processed in the context of the
Appas we need access to a reference to theActiveEventLooptocreate a new window.
Testing: servoshell is mainly untested, though a future change will add new
unit tests for multi-window functionality.
Fixes: #13997.