Allow webdriver to automatically accept custom protocol handlers#40838
Closed
TimvdLippe wants to merge 2 commits intoservo:mainfrom
Closed
Allow webdriver to automatically accept custom protocol handlers#40838TimvdLippe wants to merge 2 commits intoservo:mainfrom
TimvdLippe wants to merge 2 commits intoservo:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reads the
protocol_handler_automation_modeand if it isautoAccept, then we should eagerly register the protocol handler.We do this by updating the
ProtocolRegistryin the resource thread,where we need to clone it (since there can be ongoing fetches). To
be able to clone handlers, we need a new method on the trait.
Part of #40615