Clone request/response bodies per Fetch spec concept-body-clone#40825
Merged
Taym95 merged 3 commits intoservo:mainfrom Dec 19, 2025
Merged
Clone request/response bodies per Fetch spec concept-body-clone#40825Taym95 merged 3 commits intoservo:mainfrom
Taym95 merged 3 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#19602321468) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19602321468): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (24)
Stable unexpected results (4)
|
|
|
3 tasks
Member
Author
|
I will get back to this after #35991 is merged |
Implement clone_body_stream_for_dom_body to follow https://fetch.spec.whatwg.org/#concept-body-clone, teeing the ReadableStream and wiring the branched streams back into the original and cloned bodies. Use clone_body_stream_for_dom_body in Request::clone_from and Response::Clone so their body cloning follows the Fetch spec algorithms for request/response cloning, including the shared body stream. Signed-off-by: Taym Haddadi <[email protected]>
c7cbfee to
5161632
Compare
|
🔨 Triggering try run (#20367854479) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20367854479): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (36)
Stable unexpected results (4)
|
|
|
Signed-off-by: Taym Haddadi <[email protected]>
|
🔨 Triggering try run (#20372488913) for Linux (WPT) |
TimvdLippe
approved these changes
Dec 19, 2025
|
Test results for linux-wpt from try job (#20372488913): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (40)
|
|
✨ Try run (#20372488913) succeeded. |
Signed-off-by: Taym Haddadi <[email protected]>
64f9ea6 to
174d05c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement clone_body_stream_for_dom_body to follow https://fetch.spec.whatwg.org/#concept-body-clone, teeing the ReadableStream and wiring the branched streams back into the original and cloned bodies.
Use clone_body_stream_for_dom_body in Request::clone_from and Response::Clone so their body cloning follows the Fetch spec algorithms for request/response cloning, including the shared body stream.
Testing: more WPT test should pass.
Fixes: #36503