libservo: Have WebView take a RenderingContext rather than Servo#40794
Merged
mrobinson merged 1 commit intoservo:mainfrom Nov 21, 2025
Merged
libservo: Have WebView take a RenderingContext rather than Servo#40794mrobinson merged 1 commit intoservo:mainfrom
WebView take a RenderingContext rather than Servo#40794mrobinson merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
mukilan
approved these changes
Nov 21, 2025
servo-highfive
removed
the
S-awaiting-review
This is the last major change before we can try to implement support for multiple windows in Servo. This change makes it so that each `WebView` (via `WebViewBuilder`) takes the `RenderingContext` as an argument, rather than `Servo` (via `ServoBuilder`) as a whole. In the compositor, when registering the `RenderingContext`, if a `Painter` is found for it, it is returned. Otherwise, a new `Painter` (and WebRender instance) is created for it. There is currently no way to unregister a `RenderingContext`. We should come up with a good metric for when is the best time to clean up `Painter`s and WebRender instances for defunct `RenderingContext`s. This could perhaps be done via a `Weak` handle to the `RenderingContext`. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
libservo-webview-rendering-context
branch
from
f5e64c8 to
d202bbc
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last major change before we can try to implement support for
multiple windows in Servo. This change makes it so that each
WebView(via
WebViewBuilder) takes theRenderingContextas an argument,rather than
Servo(viaServoBuilder) as a whole.In the compositor, when registering the
RenderingContext, if aPainteris found for it, it is returned. Otherwise, a newPainter(and WebRender instance) is created for it. There is currently no way to
unregister a
RenderingContext. We should come up with a good metricfor when is the best time to clean up
Painters and WebRender instancesfor defunct
RenderingContexts. This could perhaps be done via aWeakhandle to the
RenderingContext.Testing: This should not really change observable behavior, so should be
covered by existing tests.
Fixes: #13995
Closes: #40261