script: Don't crash when encountering unexpected node types in Range::createContextualFragment#40762
Merged
simonwuelker merged 3 commits intoservo:mainfrom Nov 20, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
jdm
approved these changes
Nov 20, 2025
.../wpt/tests/html/syntax/serializing-html-fragments/range-on-pi-contextual-fragment-crash.html
Show resolved
Hide resolved
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Simon Wülker <[email protected]>
…alFragment Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
range-crash
branch
from
62cca13 to
e830f58
Compare
servo-highfive
added
the
S-awaiting-review
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56149) with upstreamable changes. |
mrobinson
approved these changes
Nov 20, 2025
servo-highfive
added
S-awaiting-review
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56149). |
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
range-crash
branch
from
6254068 to
4fc609b
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56149). |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec says that all node types other than element, text and comment should be treated as
None. We were panicking on a few instead.Testing: This change adds a simple crashtest
Fixes: #40719