compositing: Do not set scroll offsets of zero when restoring scroll offsets in new display lists#40757
Merged
mrobinson merged 1 commit intoservo:mainfrom Nov 20, 2025
Conversation
Signed-off-by: kongbai1996 <[email protected]>
servo-highfive
added
the
S-awaiting-review
mrobinson
reviewed
Nov 20, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
What is the motivation for this change? Does it affect performance?
Contributor
Author
Yes, there has been a significant reduction in the number of FrameMsg::SetScrollOffsets, which in turn greatly reduces the number of set_scroll_offsets calls in webrender_backend. This is beneficial for performance. |
mrobinson
changed the title
Member
I have added this to the PR description. |
mrobinson
approved these changes
Nov 20, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in a significant reduction in the number of
FrameMsg::SetScrollOffsets, which in turn greatly reduces the number ofset_scroll_offsetscalls in the WebRender backend. This is beneficial for performance.Testing: This is an attempt to increase performance, so is covered by existing tests.