mach: Normalize the --profile argument to build commands#40753
Merged
mukilan merged 1 commit intoservo:mainfrom Nov 20, 2025
Merged
mach: Normalize the --profile argument to build commands#40753mukilan merged 1 commit intoservo:mainfrom
--profile argument to build commands#40753mukilan merged 1 commit intoservo:mainfrom
Conversation
The current logic treats the explict version of release and dev build specification i.e the `--profile release` and `--profile dev` options as custom profiles. This breaks other logic that explictly check for release and dev profile types, like the android build. Normalize the `--profile` argument so that the strings `release` and `dev` are treated correctly as `BuildType.Kind.RELEASE` and `BuildType.Kind.DEV` respectively. Fixes: servo#40752 Signed-off-by: Mukilan Thiyagarajan <[email protected]>
servo-highfive
added
the
S-awaiting-review
jschwe
approved these changes
Nov 20, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic treats the explict version of release and dev build specification i.e the
--profile releaseand--profile devoptions as custom profiles. This breaks other logic that explictly check for release and dev profile types, like the android build.Normalize the
--profileargument so that the stringsreleaseanddevare treated correctly asBuildType.Kind.RELEASEandBuildType.Kind.DEVrespectively.Fixes: #40752
Testing: Tested manually that building android with
--profile releasecreates the correct directory structure.