Skip to content

script: Don't allocate when retrieving attribute values for layout#40724

Merged
simonwuelker merged 1 commit intoservo:mainfrom
simonwuelker:dont-allocate-for-attrs
Nov 18, 2025
Merged

script: Don't allocate when retrieving attribute values for layout#40724
simonwuelker merged 1 commit intoservo:mainfrom
simonwuelker:dont-allocate-for-attrs

Conversation

@simonwuelker
Copy link
Copy Markdown
Contributor

We end up only calling .iter on these Vecs anyways.

Testing: No behaviour change intended, regressions are covered by existing tests

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 18, 2025
Copy link
Copy Markdown
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 18, 2025
@simonwuelker simonwuelker added this pull request to the merge queue Nov 18, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 18, 2025
Merged via the queue into servo:main with commit c5da053 Nov 18, 2025
35 checks passed
@simonwuelker simonwuelker deleted the dont-allocate-for-attrs branch November 18, 2025 19:59
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants