script: Fix wrongly matched normalized algorithm in NormalizedAlgorithm::get_key_length#40686
Merged
mrobinson merged 1 commit intoservo:mainfrom Nov 17, 2025
Merged
Conversation
In `NormalizedAlgorithm::get_key_length`, we match the wrong enum variants for HKDF and PBKDF2. Therefore, the function wrongly returns `NotSupportedError` for them. It causes a few WPT tests fail. This patch fix it with correct enum variants. Testing: Pass some WPT tests that were expected to fail. Signed-off-by: Kingsley Yung <[email protected]>
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Nov 17, 2025
servo-highfive
removed
the
S-awaiting-review
mrobinson
changed the title
mrobinson
changed the title
NormalizedAlgorithm::get_key_length
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
NormalizedAlgorithm::get_key_length, we match the wrong enum variants for HKDF and PBKDF2. Therefore, the function wrongly returnsNotSupportedErrorfor them. It causes a few WPT tests fail. This patch fix it with correct enum variants.Testing: Pass some WPT tests that were expected to fail.