libservo: Make WebView::set_history have crate visibility#40671
Merged
mrobinson merged 1 commit intoservo:mainfrom Nov 16, 2025
Merged
libservo: Make WebView::set_history have crate visibility#40671mrobinson merged 1 commit intoservo:mainfrom
WebView::set_history have crate visibility#40671mrobinson merged 1 commit intoservo:mainfrom
Conversation
I mistakenly made this method have public visibility in a recent PR Signed-off-by: Martin Robinson <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Nov 16, 2025
servo-highfive
removed
the
S-awaiting-review
Member
|
I think the issue is meant for some new comers. |
servo-highfive
added
the
S-awaiting-merge
Member
Author
|
@yezhizhen I fixed this one because I originally made the mistake. |
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mistakenly made this method have public visibility in a recent PR
Testing: This doesn't change behavior and is thus covered by existing tests.
Fixes: #40667