script: Don't rely on Attr nodes when communicating with layout#40657
Merged
jdm merged 1 commit intoservo:mainfrom Nov 15, 2025
Merged
script: Don't rely on Attr nodes when communicating with layout#40657jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Simon Wülker <[email protected]>
|
🔨 Triggering try run (#19393146345) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19393146345): Flaky unexpected result (44)
Stable unexpected results that are known to be intermittent (33)
|
|
✨ Try run (#19393146345) succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When script is looking up an attribute for layout then it only needs to care about the attribute value. The
Attrnode itself is not required. If we want to lazily construct attribute nodes in the future (#36697) then we should useAttras little as possible.This also ends up simplifying the code by accident.
Testing: No behaviour change intended, regressions are covered by existing tests.
Part of #36697