net: Relax the SVG content type detection logic.#40636
Merged
mukilan merged 2 commits intoservo:mainfrom Nov 17, 2025
Merged
Conversation
The current logic fails when the `Content-Type` header includes the character encoding other parameters like `qs`. Fixes: servo#40630 Signed-off-by: Mukilan Thiyagarajan <[email protected]>
|
🔨 Triggering try run (#19356477888) for Linux (WPT) |
TimvdLippe
reviewed
Nov 14, 2025
|
Test results for linux-wpt from try job (#19356477888): Flaky unexpected result (46)
Stable unexpected results that are known to be intermittent (26)
|
|
✨ Try run (#19356477888) succeeded. |
Contributor
|
Can we add a WPT test for this, given none started passing with this fix? |
Signed-off-by: Mukilan Thiyagarajan <[email protected]>
19cf19c to
5cc962e
Compare
|
🔨 Triggering try run (#19423234692) for Linux (WPT) |
Member
Author
|
I've added a new WPT test in 5cc962e |
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56050) with upstreamable changes. |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56050). |
|
Test results for linux-wpt from try job (#19423234692): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (2)
|
|
|
TimvdLippe
approved these changes
Nov 17, 2025
Collaborator
|
⛔ Failed to properly merge the upstream pull request (web-platform-tests/wpt#56050). Please address any CI issues and try to merge manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic fails when the
Content-Typeheader includes the character encoding other parameters likeqs.Fixes: #40630