layout: Adjust inset-modified containing block to have non-negative size#40628
Merged
Loirooriol merged 3 commits intoservo:mainfrom Nov 17, 2025
Merged
layout: Adjust inset-modified containing block to have non-negative size#40628Loirooriol merged 3 commits intoservo:mainfrom
Loirooriol merged 3 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#19351988925) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19351988925): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (33)
|
|
✨ Try run (#19351988925) succeeded. |
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56029) with upstreamable changes. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56029) title and body. |
e13ecf2 to
7390065
Compare
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56029) title and body. |
We were storing the computed offsets, deferring the resolution of percentages. Now we will resolve percentages at the beginning. Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
7390065 to
e5b6f98
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56029). |
1 similar comment
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56029). |
mrobinson
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the insets of an absolutely positioned box are big enough that the inset-modified containing block (IMCB) would get a negative size, we will now adjust the weaker inset so that the size of the IMCB becomes zero instead.
This affects auto sizes, auto margins, and self-alignment.
This behavior matches Blink for the most part. However, while Blink also ensures a non-negative IMCB size, it doesn't necessarily do so by adjusting the weaker inset, so the alignment may differ.
Blink is fine with adopting this behavior, as resolved by the CSSWG in w3c/csswg-drafts#11478
Testing: Adding new WPT