servodriver: Shut down Servo elegantly when all tests finish#40455
Merged
yezhizhen merged 5 commits intoservo:mainfrom Nov 16, 2025
Merged
servodriver: Shut down Servo elegantly when all tests finish#40455yezhizhen merged 5 commits intoservo:mainfrom
yezhizhen merged 5 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#19134282694) for Linux (WPT) |
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55907) with upstreamable changes. |
yezhizhen
changed the title
yezhizhen
changed the title
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#55907) title and body. |
1 similar comment
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#55907) title and body. |
|
Test results for linux-wpt from try job (#19134282694): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (11)
|
Member
Author
|
I started 6 actions in my fork. It seems 50% of executors can finish, but rest all stuck around 90% indefinitely. I will fix this tomorrow. |
jschwe
reviewed
Nov 6, 2025
| conn.request("GET", "/status") | ||
| res = conn.getresponse() | ||
| except Exception: | ||
| self.logger.info("Servo has shutted down normally.") |
Member
There was a problem hiding this comment.
Suggested change
| self.logger.info("Servo has shutted down normally.") | |
| self.logger.info("Servo has shut down normally.") |
Should this perhaps also be debug? info seems very verbose.
Member
Author
There was a problem hiding this comment.
Yeah. Do you know how can I make things appear in console, if I use debug?
jschwe
reviewed
Nov 6, 2025
| self.logger.info(f"Got response status for shutdown command: {res.status}") | ||
| # 0.05 is a heuristic value manually tested, after which servo always shutted down. | ||
| time.sleep(0.05) | ||
| while self.is_alive(): |
Member
There was a problem hiding this comment.
do we perhaps want a timeout here after a couple of tries?
Member
Author
There was a problem hiding this comment.
You mean kill the process? Will that result in empty coverage report?
Member
There was a problem hiding this comment.
it will result in a missing profile (so the coverage would be missing information from that process / test-run), but better than hanging forever. We could print a warning, if the regular shutdown failed.
Member
Author
There was a problem hiding this comment.
Yeah, ideally I wanna avoid it. But I tried several different approaches, including sending shutdown requests repeatedly. There is no way around, and we have to kill it unfortunately.
With 10000 more unshown retries... This exposes some bug that Servo cannot be shut down.
Contributor
|
🔨 Triggering try run (#19155439487) for Linux (WPT) |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55907). |
|
Test results for linux-wpt from try job (#19155439487): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (16)
|
|
🔨 Triggering try run (#19156647195) for Linux (WPT) |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55907). |
|
Test results for linux-wpt from try job (#19156647195): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (8)
|
|
🔨 Triggering try run (#19158949680) for Linux (WPT) |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55907). |
|
Test results for linux-wpt from try job (#19158949680): Flaky unexpected result (43)
Stable unexpected results that are known to be intermittent (22)
|
Member
Author
I still don't know why.. This seems so magical. Now 95% can finish; remaining 5% executor stuck at 90%... Will check log later. |
|
🔨 Triggering try run (#19319611504) for Linux (WPT) |
|
Test results for linux-wpt from try job (#19319611504): Flaky unexpected result (42)
Stable unexpected results that are known to be intermittent (31)
|
|
✨ Try run (#19319611504) succeeded. |
Member
|
@yezhizhen Is this ready for review? |
Member
Author
yes. |
mrobinson
approved these changes
Nov 14, 2025
tests/wpt/tests/tools/wptrunner/wptrunner/browsers/servodriver.py
Outdated
Show resolved
Hide resolved
tests/wpt/tests/tools/wptrunner/wptrunner/browsers/servodriver.py
Outdated
Show resolved
Hide resolved
tests/wpt/tests/tools/wptrunner/wptrunner/browsers/servodriver.py
Outdated
Show resolved
Hide resolved
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
- Add retry Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
change-wpt
branch
from
d3ad52c to
f97b92f
Compare
servo-highfive
added
the
S-awaiting-review
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55907). |
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
change-wpt
branch
from
f97b92f to
1b4fdec
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#55907). |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Collaborator
|
⛔ Failed to properly merge the upstream pull request (web-platform-tests/wpt#55907). Please address any CI issues and try to merge manually. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
I like `servo` runner, or better known as its previous name `servodriver` to some people. However, it is getting quite often that I use `legacy`, or better known as its previous name `servo`. This is because `servo (previously servodriver)` harness shutdown very slowly due to its shutdown command #40455 - This PR improves the shutdown command in the way as titled. - Avoids accidental Prockill that may happen after regular shutdown. This may be related to @jschwe's report that coverage for WPT still reports empty more often than it should. Previously, shutdown is like: ``` 0:15.06 INFO Trying to shut down gracefully by extension command 0:18.13 DEBUG Servo has shut down normally. HTTPConnectionPool(host='127.0.0.1', port=8378): Max retries exceeded with url: /status (Caused by NewConnectionError("HTTPConnection(host='127.0.0.1', port=8378): Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it")) 0:18.13 DEBUG Stopping WebDriver 0:20.19 DEBUG Servo has shut down normally. HTTPConnectionPool(host='127.0.0.1', port=8378): Max retries exceeded with url: /status (Caused by NewConnectionError("HTTPConnection(host='127.0.0.1', port=8378): Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it")) 0:22.24 DEBUG Servo has shut down normally. HTTPConnectionPool(host='127.0.0.1', port=8378): Max retries exceeded with url: /status (Caused by NewConnectionError("HTTPConnection(host='127.0.0.1', port=8378): Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it")) 0:14.99 DEBUG Hanging up on WebDriver session ``` Now: ``` INFO Trying to shut down gracefully by extension command 0:18.41 DEBUG Servo has shut down normally. HTTPConnectionPool(host='127.0.0.1', port=9098): Max retries exceeded with url: /status (Caused by NewConnectionError("HTTPConnection(host='127.0.0.1', port=9098): Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it")) 0:18.41 DEBUG TestRunnerManager cleanup 0:15.30 DEBUG Hanging up on WebDriver session ``` Testing: Locally, this reduce shutdown time from about 5 sec to 1 sec, counting from "Trying to shut down gracefully by extension command". [Try](https://github.com/servo/servo/actions/runs/22295662553/job/64492009162). Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we always kill the instance when tests finish instead of normally shutting down. That blocked clean-ups works, such as Code Coverage we wanted to add, and other things I'm not aware of.
Testing: We have tested for a week and checked the logs of CI to confirm it works normally now.