script: Eagerly update the Device in Layout when it changes#40432
Merged
mrobinson merged 1 commit intoservo:mainfrom Nov 5, 2025
Merged
script: Eagerly update the Device in Layout when it changes#40432mrobinson merged 1 commit intoservo:mainfrom
Device in Layout when it changes#40432mrobinson merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
nicoburns
approved these changes
Nov 5, 2025
servo-highfive
removed
the
S-awaiting-review
mrobinson
force-pushed
the
update-device-immediately
branch
from
0c5b2b0 to
d29be5f
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
Instead of waiting for a reflow to update the `Device` in layout, update it eagerly. This ensures that media queries can be answered correctly in script before the next reflow. Also, it ensure that a new reflow is triggered and reflects the change to the theme or viewport. In addition, an unused viewport-related message from the Constellation is removed. This would have needed to be updated by change, but since it's unused I've just removed it. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
update-device-immediately
branch
from
d29be5f to
294a125
Compare
servo-highfive
removed
the
S-tests-failed
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of waiting for a reflow to update the
Devicein layout, updateit eagerly. This ensures that media queries can be answered correctly in
script before the next reflow. Also, it ensure that a new reflow is
triggered and reflects the change to the theme or viewport.
In addition, an unused viewport-related message from the Constellation
is removed. This would have needed to be updated by change, but since
it's unused I've just removed it.
This depends on servo/stylo#260.
Testing: This fixes a WebView API test and improves
/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html.Fixes: #40395.
Fixes: #40129.