Skip to content

script: Do not include transforms and inline boxes in ResizeObserver box area queries#40323

Merged
jdm merged 2 commits intoservo:mainfrom
jdm:resize-observer-inline
Nov 3, 2025
Merged

script: Do not include transforms and inline boxes in ResizeObserver box area queries#40323
jdm merged 2 commits intoservo:mainfrom
jdm:resize-observer-inline

Conversation

@jdm
Copy link
Copy Markdown
Member

@jdm jdm commented Oct 31, 2025

These changes implement the restrictions for content rects required by the ResizeObserver specification: inline boxes must return empty rects, and any transforms must be ignored.

Testing: Newly passing tests.
Fixes: #40259
Fixes: #40258

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 31, 2025
@TimvdLippe TimvdLippe added the S-needs-rebase There are merge conflict errors. label Nov 1, 2025
@jdm jdm force-pushed the resize-observer-inline branch from ecf8482 to 4c3c976 Compare November 2, 2025 13:32
@servo-highfive servo-highfive removed the S-needs-rebase There are merge conflict errors. label Nov 2, 2025
@jdm jdm mentioned this pull request Nov 2, 2025
9 tasks
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 3, 2025
@mrobinson mrobinson changed the title script: Limit ResizeObserver box area queries script: Do not include transforms and inline boxes in ResizeObserver box area queries Nov 3, 2025
@jdm jdm added this pull request to the merge queue Nov 3, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 3, 2025
Merged via the queue into servo:main with commit 61f98c5 Nov 3, 2025
34 checks passed
@jdm jdm deleted the resize-observer-inline branch November 3, 2025 16:05
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants