compositor: Make new frame notifications per Painter#40309
Merged
mukilan merged 1 commit intoservo:mainfrom Oct 31, 2025
Merged
compositor: Make new frame notifications per Painter#40309mukilan merged 1 commit intoservo:mainfrom
mukilan merged 1 commit intoservo:mainfrom
Conversation
mukilan
requested review from
Loirooriol,
mrobinson and
nicoburns
as code owners
servo-highfive
added
S-awaiting-review
mukilan
force-pushed
the
new-frame-notifications-per-painter
branch
from
606064d to
d388c7d
Compare
mrobinson
approved these changes
Oct 31, 2025
servo-highfive
removed
the
S-awaiting-review
Track the `PainterId` in the `RenderNotifier` and use it to ensure needs_repaint is set independently for each `Painter`. This allows us to post new frame notifications only to the painters that WebRender notified us about. Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Mukilan Thiyagarajan <[email protected]>
mukilan
force-pushed
the
new-frame-notifications-per-painter
branch
from
d388c7d to
6a8a455
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
Track the `PainterId` in the `RenderNotifier` and use it to ensure needs_repaint is set independently for each `Painter`. This allows us to post new frame notifications only to the painters that WebRender notified us about. Testing: Should be covered by existing tests. Signed-off-by: Mukilan Thiyagarajan <[email protected]> Co-authored-by: Martin Robinson <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track the
PainterIdin theRenderNotifierand use it to ensure needs_repaint is set independently for eachPainter. This allows us to post new frame notifications only to the painters that WebRender notified us about.Testing: Should be covered by existing tests.