compositor: Rename RenderingGroupId to PainterId#40307
Merged
mrobinson merged 1 commit intoservo:mainfrom Oct 31, 2025
Merged
Conversation
mukilan
requested review from
Loirooriol,
mrobinson and
nicoburns
as code owners
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Oct 31, 2025
servo-highfive
removed
the
S-awaiting-review
And let the Compositor create the `PainterId` when it creates a new `Painter`. Also make inline formatting code take `LayoutContext` rather than threading it via the `InlineFormattingContextBuilder`. Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Mukilan Thiyagarajan <[email protected]>
mrobinson
force-pushed
the
rename-rendering-group-id-to-painter-id
branch
from
e6cf16f to
9585da1
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And let the Compositor create the
PainterIdwhen it creates a newPainter. Also make inline formatting code takeLayoutContextrather than threading it via theInlineFormattingContextBuilder.Testing: Should preserve existing behavior, so covered by existing tests.