script: Report target padding and desired sizes for ResizeObserver notifications#40254
Merged
jdm merged 7 commits intoservo:mainfrom Oct 31, 2025
Merged
script: Report target padding and desired sizes for ResizeObserver notifications#40254jdm merged 7 commits intoservo:mainfrom
jdm merged 7 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
Loirooriol
reviewed
Oct 29, 2025
mrobinson
approved these changes
Oct 30, 2025
servo-highfive
added
S-needs-rebase
…puting content rect. Signed-off-by: Josh Matthews <[email protected]>
… box. Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
Signed-off-by: Josh Matthews <[email protected]>
jdm
force-pushed
the
resize-observer-padding
branch
from
ec14234 to
1921aef
Compare
servo-highfive
added
S-awaiting-review
Signed-off-by: Josh Matthews <[email protected]>
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not following the specification for computing the values of the content rect. Additionally, any non-content-box observer would get confused because we never stored the correct size, leading to infinite notifications when the latest size didn't match the last observed size.
Testing: Various tests now pass.
Fixes: #32549
Fixes: #40107