add CanGc as argument to methods in OscillatorNode and StereoPannerNode#40146
Merged
jdm merged 1 commit intoservo:mainfrom Oct 25, 2025
Merged
add CanGc as argument to methods in OscillatorNode and StereoPannerNode#40146jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
yerke
force-pushed
the
replace-remaining-CanGc-note-part-12
branch
from
e141e85 to
e0cd636
Compare
Contributor
Author
|
@jdm Here is one for OscillatorNode and StereoPannerNode |
Signed-off-by: Yerkebulan Tulibergenov <[email protected]>
yerke
force-pushed
the
replace-remaining-CanGc-note-part-12
branch
from
e0cd636 to
e1138ff
Compare
jdm
approved these changes
Oct 25, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add CanGc as argument to methods in OscillatorNode and StereoPannerNode
Testing: These changes do not require tests because they are a refactor.
Addresses part of #34573.