script: Replace IndexedDB's unsafe uses of RootedVec<JSVal>.#40143
Merged
jdm merged 1 commit intoservo:mainfrom Oct 25, 2025
Merged
script: Replace IndexedDB's unsafe uses of RootedVec<JSVal>.#40143jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Josh Matthews <[email protected]>
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Oct 24, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #40141 is filed to address the complete unsafe pattern, fixing the instances of this within the IndexedDB code is something that can happen today. It is not safe to store raw GC values inside of RootedVec; they need to be inside Heap wrappers, and those can't be stored in a vector that can reallocate without being wrapped inside of a Box.
Testing: Fixes an intermittent crashing test.
Fixes: #39766