servoshell: Cleanup headed_window from the old code#40132
Merged
mrobinson merged 1 commit intoservo:mainfrom Oct 24, 2025
Merged
servoshell: Cleanup headed_window from the old code#40132mrobinson merged 1 commit intoservo:mainfrom
mrobinson merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Rodion Borovyk <[email protected]>
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Oct 24, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Yes, it seems that WinitKey::Character now contains the full string of inserted text.
servo-highfive
removed
the
S-awaiting-review
yezhizhen
added
T-webdriver
Member
|
Cancelling as it's headed window. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
headed_window.rshad some old code that apparently does not make sense with the newer versions of winit or other parts of Servo and also introduced #40073. For example, some comments referred to winit'sReceivedCharevent orEmbedderMsg::Keyboardwhich do not exist anymore.These changes remove the old code and simplify handling of keyboard events.
Testing: Servoshell was tested manually except for WebXR features because it looks like I'do not have proper hardware to test WebXR.
Fixes: #40073