xpath: Verify context node in XPathExpression::evaluate_internal#40105
Merged
simonwuelker merged 1 commit intoservo:mainfrom Oct 24, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
simonwuelker
force-pushed
the
xpath-context-node-verification
branch
from
8997e6a to
5a734a8
Compare
jdm
approved these changes
Oct 23, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
jdm
added
S-fails-tidy
Signed-off-by: Simon Wülker <[email protected]>
simonwuelker
force-pushed
the
xpath-context-node-verification
branch
from
5a734a8 to
07b6399
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evaluate_internalis the common code path used when evaluating an expression, so any verification that always applies must happen there.Testing: This change adds a test
Fixes #40104
Part of #34527