script: implement remaining WorkerGlobalScope's event handlers#40102
Merged
jdm merged 5 commits intoservo:mainfrom Oct 23, 2025
Merged
script: implement remaining WorkerGlobalScope's event handlers#40102jdm merged 5 commits intoservo:mainfrom
jdm merged 5 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#18746023430) for Linux (WPT) |
mrobinson
reviewed
Oct 23, 2025
|
Test results for linux-wpt from try job (#18746023430): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (25)
Stable unexpected results (3)
|
|
|
mrobinson
reviewed
Oct 23, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Nice change! LGTM with one small modification.
jdm
approved these changes
Oct 23, 2025
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
c24269f to
7269f2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up WorkerGlobalScope webidl interface and implement all event handlers that WorkerGlobalScope and subclasses should support.
Testing: Covered by existing tests, needs to update test expectations.