Conversation
Signed-off-by: Josh Matthews <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Oct 23, 2025
| ))) | ||
| }) | ||
| .map_err(move |error| { | ||
| warn!("network error: {error:?}"); |
Member
There was a problem hiding this comment.
I'm curious why is it warn! instead of error!.
Member
Author
There was a problem hiding this comment.
I tend to use error! for things that are wrong in the engine, and warn! for things that are possible but worth highlighting when reading debug logs.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently lose information when there are connection issues with HTTP requests. Until we figure out a better architecture for exposing error data from crates that we don't control, we can at least log messages like
WARN net::http_loader] network error: hyper_util::client::legacy::Error(Connect, Custom { kind: Other, error: Custom { kind: InvalidData, error: AlertReceived(HandshakeFailure) } }.Testing: Manually confirmed console output for fsf.org with RUST_LOG=net.